[laptop-mode] [PATCH] do not show drive power status if CONTROL_HD_POWERMGMT is disabled

[Olivier Blin]

Ritesh Raj Sarraf <rrs at researchut.com> writes:

> On Tuesday 15 Sep 2009 16:58:23 Olivier Blin wrote:
>> > On Monday 14 Sep 2009 23:38:29 Olivier Blin wrote:
>> >> Do not show drive power status if CONTROL_HD_POWERMGMT is disabled
>> >> (some USB harddisks disconnect after using hdparm -C or -B)
>> >> 
>> >> This might now be the best approach to workaround the hardware bug, but
>> >> it does not look so useful to show drive power status if
>> >> laptop-mode-tools is configured not to handle drive power.
>> 
>
> Hmmm!! I do have a USB HDD but I don't boot of it.
> But I've tested External USB HDD Laptop Drives and they've worked.
> Your case could be a driver bug (bugzilla ?) or as you said, just faulty 
> hardware.

Hi,

I think it is faulty hardware (it is a USB disk with built-in
encryption).

> BTW, I just looked into the config file.
>
> #
> # The drives that laptop mode controls.
> # Separate them by a space, e.g. HD="/dev/hda /dev/hdb". The default is a
> # wildcard, which will get you all your IDE and SCSI/SATA drives.
> #
> HD="/dev/[hs]d[abcdefgh]"
>
> Why don't you just be explicit in defining what all drives laptop-mode-tools 
> should query ?

Right, that's a reasonnable solution, and it prevents from cluttering
the laptop-mode-tools code with strange workarounds for faulty hardware.

Thanks!

-- 
Olivier Blin (blino) - Mandriva